Skip to content

upgrade to polkadot-v0.9.40#350

Merged
b-yap merged 9 commits intomainfrom
219-update-runtimes-to-polkadot-v0940
Jun 1, 2023
Merged

upgrade to polkadot-v0.9.40#350
b-yap merged 9 commits intomainfrom
219-update-runtimes-to-polkadot-v0940

Conversation

@b-yap
Copy link
Contributor

@b-yap b-yap commented May 25, 2023 •
edited
Loading

partially closes pendulum issue 219.

I have updated the weights as well, since a lot of the pallets are #![deny(warnings)].

summary of changes:

  1. rename grandpa traits
  2. deprecated trait store
  3. hash instead of BlockId
  4. deprecated from_ref..., changed to from_parts() function

Specific to clients directory:

  1. Rename *-private-ipv4 to *-private-ip CLI args

Specific to testchain directory:

  1. update batching api in chain spec
  2. rename warp_sync to warp_sync_params
  3. Extract syncing protocol from sc-network
  4. Add WeightToFee and LengthToFee impls to transaction-payment Runtime API
  5. KeyOwnerProofSystem of grandpa removed

extra:

  1. cleanup based on this suggestion.
  2. fix failing test_check_slot_position test case after updating the MAX_SLOTS_TO_REMEMBER value.

@b-yap b-yap requested a review from a team May 25, 2023 05:23
@b-yap
Copy link
Contributor Author

b-yap commented May 25, 2023

@ebma the weights have increased. You can check each extrinsic's comments from the benchmark.
I can always replace from_ref_time with from_parts, if you find the numbers too big/unreasonable.

ebma
ebma approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding all these changes @b-yap 🙏

I see that the weights changed indeed. Sometimes the execution time varies just a little and sometimes the weights doubled (which might look confusing at first since the weight comments now state everything in pico seconds, but since pico is 1e-3 smaller than nano and the values mostly have three additional 0s now, they are pretty similar.) But it could be that the fact that you were now using --execution=wasm also amplified this variation. It's great though that you managed to use that parameter as it's preferred and should be more accurate AFAIK. I only did not use it before because it did not work for some reason.

Maybe we can fix some of the CI warnings but besides that it's good to go 👍

pallets/fee/src/default_weights.rs
// --extrinsic=*
// --chain
// dev
// --execution=wasm
Copy link
Member

@ebma ebma May 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, since when does it work with wasm? That's great. I remember when I created all the benchmarks a while ago this parameter was not working and unfortunately I was not able to figure out why. Great that it works now

pallets/issue/src/benchmarking.rs Outdated
Comment on lines +67 to +68
// this amount is when running the benchmark with the testchain
// let amount = 1000_0000u32.into();
Copy link
Member

@ebma ebma May 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this comment? I need to change the amount when running benchmarks with the testchain but use the 1000 otherwise? Can we change it such that it always uses 100_00000u32 then so that it works in both cases?

Copy link
Contributor Author

@b-yap b-yap Jun 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed amount to the fixed 1000_0000u32.into()

b-yap added a commit that referenced this pull request May 30, 2023
@b-yap
https://github.com/pendulum-chain/spacewalk/pull/350#discussion_r1206…
407d32b 
…408348,

#350 (comment),
#350 (comment)
@b-yap b-yap force-pushed the 219-update-runtimes-to-polkadot-v0940 branch from 407d32b to 365d3f4 Compare May 31, 2023 03:17
@b-yap b-yap merged commit 06873f1 into main Jun 1, 2023
@b-yap b-yap deleted the 219-update-runtimes-to-polkadot-v0940 branch June 1, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebma ebma ebma approved these changes

+1 more reviewer

@TorstenStueber TorstenStueber TorstenStueber approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update runtimes to polkadot-v0.9.40

3 participants

@b-yap @ebma @TorstenStueber